This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
specify replica-signed queries #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ic-interface-spec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
nomeata
reviewed
May 31, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ShuoWangNSL
reviewed
Aug 2, 2023
ShuoWangNSL
reviewed
Aug 5, 2023
ShuoWangNSL
reviewed
Aug 9, 2023
✅ Deploy Preview for ic-interface-spec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mraszyk
commented
Aug 18, 2023
ShuoWangNSL
reviewed
Aug 18, 2023
THLO
reviewed
Aug 28, 2023
THLO
reviewed
Aug 28, 2023
THLO
reviewed
Aug 28, 2023
THLO
reviewed
Aug 28, 2023
Co-authored-by: Thomas Locher <thomas.locher@dfinity.org>
Co-authored-by: Thomas Locher <thomas.locher@dfinity.org>
gitlab-dfinity
pushed a commit
to dfinity/ic
that referenced
this pull request
Sep 13, 2023
…de-signatures' into 'master' feat: [IC-1247] Add replica signatures to Query responses This MR adds replica signatures to Query responses. A hash of a Query is computed as described in [PR#136](dfinity/interface-spec#163), signed with `sign_basic` and included in the query response. Part of IC-1247 Closes NET-1500 Co-authored-by: Shuo Wang shuo.wang@dfinity.org \ Co-authored-by: Martin Raszyk martin.raszyk@dfinity.org Closes NET-1500 See merge request dfinity-lab/public/ic!13833
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds public keys of nodes in a subnet to the certified state tree and specifies query call response signatures produced by nodes evaluating the query call and returned as part of the query response.