Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

housekeeping: Refactors SettingsButton into a link #5877

Merged
merged 4 commits into from
Nov 29, 2024
Merged

housekeeping: Refactors SettingsButton into a link #5877

merged 4 commits into from
Nov 29, 2024
+27 −24

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Nov 28, 2024 •
edited
Loading

Motivation

SettingsButton is a button that triggers a page redirect. An anchor is a more semantically correct HTML element for such a component.

It can be checked here

Changes

  • Refactors SettingsButton into LinkToSettings

Tests

  • Updates impacted tests
  • Manually tested

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib changed the title housekeeping: Refactors AccountMenu buttons into links housekeeping: Refactors SettingsButton into a link Nov 29, 2024
@yhabib yhabib marked this pull request as ready for review November 29, 2024 09:10
@yhabib yhabib requested a review from a team as a code owner November 29, 2024 09:10
mstrasinskis
mstrasinskis approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@yhabib yhabib added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 714e99e Nov 29, 2024
30 checks passed
@yhabib yhabib deleted the yhabib/housekeeping/account-menu-links branch November 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @mstrasinskis