From 361aa82d3bb99793b2ecbeb8db11d25c791c3c48 Mon Sep 17 00:00:00 2001 From: marvinfriede <51965259+marvinfriede@users.noreply.github.com> Date: Sun, 15 Dec 2024 09:26:15 -0600 Subject: [PATCH] Fix zizmor security issues in GA --- .github/workflows/codeql.yml | 10 ++++++---- .github/workflows/macos-arm.yaml | 10 ++++++++-- .github/workflows/macos-x86.yaml | 10 ++++++++-- .github/workflows/release.yaml | 4 ++++ .github/workflows/ubuntu.yaml | 12 +++++++++--- .github/workflows/windows.yaml | 10 ++++++++-- 6 files changed, 43 insertions(+), 13 deletions(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 99ba747..98a2b2b 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -2,9 +2,9 @@ name: "CodeQL" on: push: - branches: [ "main" ] + branches: ["main"] pull_request: - branches: [ "main" ] + branches: ["main"] schedule: - cron: "25 21 * * 5" @@ -20,11 +20,13 @@ jobs: strategy: fail-fast: false matrix: - language: [ python ] + language: [python] steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 + with: + persist-credentials: false - name: Initialize CodeQL uses: github/codeql-action/init@v2 diff --git a/.github/workflows/macos-arm.yaml b/.github/workflows/macos-arm.yaml index 367cb22..f785470 100644 --- a/.github/workflows/macos-arm.yaml +++ b/.github/workflows/macos-arm.yaml @@ -73,6 +73,8 @@ jobs: steps: - name: Checkout code uses: actions/checkout@v3 + with: + persist-credentials: false - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v5 @@ -88,7 +90,11 @@ jobs: run: echo "TOXENV=py$(echo ${{ matrix.python-version }} | tr -d '.')-torch$(echo ${{ matrix.torch-version }} | tr -d '.')" >> $GITHUB_ENV - name: Print TOXENV - run: echo "TOXENV is set to '${{ env.TOXENV }}'." + run: echo "TOXENV is set to '${TOXENV}'." + env: + TOXENV: ${{ env.TOXENV }} - name: Unittests with tox - run: tox -e ${{ env.TOXENV }} + run: tox -e $TOXENV + env: + TOXENV: ${{ env.TOXENV }} diff --git a/.github/workflows/macos-x86.yaml b/.github/workflows/macos-x86.yaml index acdef16..5aa3799 100644 --- a/.github/workflows/macos-x86.yaml +++ b/.github/workflows/macos-x86.yaml @@ -84,6 +84,8 @@ jobs: steps: - name: Checkout code uses: actions/checkout@v3 + with: + persist-credentials: false - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v5 @@ -99,7 +101,11 @@ jobs: run: echo "TOXENV=py$(echo ${{ matrix.python-version }} | tr -d '.')-torch$(echo ${{ matrix.torch-version }} | tr -d '.')" >> $GITHUB_ENV - name: Print TOXENV - run: echo "TOXENV is set to '${{ env.TOXENV }}'." + run: echo "TOXENV is set to '${TOXENV}'." + env: + TOXENV: ${{ env.TOXENV }} - name: Unittests with tox - run: tox -e ${{ env.TOXENV }} + run: tox -e $TOXENV + env: + TOXENV: ${{ env.TOXENV }} diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 748fc97..6f996b3 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -33,6 +33,8 @@ jobs: steps: - name: Checkout code uses: actions/checkout@v3 + with: + persist-credentials: false - name: Build wheel (bdist) run: pipx run build --wheel @@ -47,6 +49,8 @@ jobs: steps: - name: Checkout code uses: actions/checkout@v3 + with: + persist-credentials: false - name: Build source distribution (sdist) run: pipx run build --sdist diff --git a/.github/workflows/ubuntu.yaml b/.github/workflows/ubuntu.yaml index 2aaae45..1f8d91f 100644 --- a/.github/workflows/ubuntu.yaml +++ b/.github/workflows/ubuntu.yaml @@ -90,6 +90,8 @@ jobs: steps: - name: Checkout code uses: actions/checkout@v3 + with: + persist-credentials: false - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v5 @@ -105,13 +107,17 @@ jobs: run: echo "TOXENV=py$(echo ${{ matrix.python-version }} | tr -d '.')-torch$(echo ${{ matrix.torch-version }} | tr -d '.')" >> $GITHUB_ENV - name: Print TOXENV - run: echo "TOXENV is set to '${{ env.TOXENV }}'." + run: echo "TOXENV is set to '${TOXENV}'." + env: + TOXENV: ${{ env.TOXENV }} - name: Unittests with tox - run: tox -e ${{ env.TOXENV }} + run: tox -e $TOXENV + env: + TOXENV: ${{ env.TOXENV }} - name: Upload coverage to Codecov - uses: codecov/codecov-action@v3 + uses: codecov/codecov-action@7f8b4b4bde536c465e797be725718b88c5d95e0e # 5.1.1 if: > matrix.python-version == '3.11' && matrix.torch-version == '2.2.2' && diff --git a/.github/workflows/windows.yaml b/.github/workflows/windows.yaml index a967b68..e6cd6a6 100644 --- a/.github/workflows/windows.yaml +++ b/.github/workflows/windows.yaml @@ -82,6 +82,8 @@ jobs: steps: - name: Checkout code uses: actions/checkout@v3 + with: + persist-credentials: false - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v5 @@ -97,7 +99,11 @@ jobs: run: echo "TOXENV=py$(echo ${{ matrix.python-version }} | tr -d '.')-torch$(echo ${{ matrix.torch-version }} | tr -d '.')" >> $GITHUB_ENV - name: Print TOXENV - run: echo "TOXENV is set to '${{ env.TOXENV }}'." + run: echo "TOXENV is set to '${TOXENV}'." + env: + TOXENV: ${{ env.TOXENV }} - name: Unittests with tox - run: tox -e ${{ env.TOXENV }} + run: tox -e $TOXENV + env: + TOXENV: ${{ env.TOXENV }}