Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0 Planning #83

Closed
2 of 5 tasks
dgasmith opened this issue Feb 20, 2019 · 12 comments
Closed
2 of 5 tasks

v3.0 Planning #83

dgasmith opened this issue Feb 20, 2019 · 12 comments
Labels

Comments

@dgasmith
Copy link
Owner

dgasmith commented Feb 20, 2019

We are planning a major version bump for the following reasons:

TODO Items:

  • Refactoring in preparation for NEP18 (NumPy Dispatch Mechanisms #46) should be considered.
  • Consider adding a Ricci calculus parser contract('A_ij B_jk A_kl', {"A": a, "B": b}).
  • Run through the backends to check where we can refactor.
  • Update docs and README to reflect that we are NumPy agnostic.
  • Consider parsers that use metrics besides raw FLOPS (actually trying out several contraction paths for example).

Are there other items where we might need to do a few (small) compatibility breaks that would be good for future sustainability?

@jcmgray
Copy link
Collaborator

jcmgray commented Feb 20, 2019

Another small thing might be to fully deprecate/remove the path kwarg.

@dgasmith
Copy link
Owner Author

dgasmith commented Jul 3, 2019

I think a lot of the above involves somewhat wishlist items. Becoming backend agnostic is the primary change that requires a 3.0. I believe the only real TODO is to make a docs pass to reflect this change.

@fritzo Would you mind double checking that Pyro works with the current master? I will follow up with other projects before we make this change.

@dgasmith dgasmith mentioned this issue Jul 3, 2019
1 task
@fritzo
Copy link
Contributor

fritzo commented Jul 3, 2019

@dgasmith thanks for the ping. Yes Pyro appears to work with opt_einsum master.

@dgasmith
Copy link
Owner Author

dgasmith commented Jul 3, 2019

@fritzo Awesome! Thanks for checking.

@dgasmith
Copy link
Owner Author

dgasmith commented Jul 17, 2019

We haven't talked about NEP18 much, but looking into current implementations there is effectively nothing for us to do beyond slowly removing the current backend technology as more packages pick up this standard. Realistically, this likely means no actions for six months to a year as this is hammered out.

Beyond that, I think a decision on #91 is the last thing we need to do here?

@dgasmith
Copy link
Owner Author

dgasmith commented Aug 7, 2019

Since @Thenerdstation is looking for new features I will work on the 3.0 release this week. @jcmgray @fritzo any blockers here?

@fritzo
Copy link
Contributor

fritzo commented Aug 7, 2019

@dgasmith I see no blockers from Pyro.

@chaserileyroberts
Copy link

We don't really have any feature requests other than the Cython implementation, which I'm happy to try to help build!

@dgasmith
Copy link
Owner Author

dgasmith commented Aug 7, 2019

That would be fantastic on the Cython implementation! I will try to jot down some notes on your issue this weekend about possible pitfalls and enhancements.

@jcmgray
Copy link
Collaborator

jcmgray commented Aug 7, 2019

No blockers from me. And cython versions of the path optimizers would be fantastic I think.

@dgasmith dgasmith mentioned this issue Aug 10, 2019
3 tasks
@dgasmith
Copy link
Owner Author

v3 release minted, if anyone would like to try out the code before I push out releases to PyPI/Conda let me know.

@dgasmith
Copy link
Owner Author

v3 on PyPI and now rolling out to conda-forge. Thank you everyone for many excellent features this release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants