release/v1.6 - Rework DB.DropPrefix (#1381) #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes three issues with the current implementation: - It can generate compaction requests that break the invariant that bottom tables need to be consecutive (issue #1380). See #1380 (comment) - It performs the same level compactions in increasing order of levels (starting from L0) which leads to old versions of keys for the prefix re-surfacing to active transactions. - When you have to drop multiple prefixes, the API forces you to drop one prefix at a time and go through the whole expensive table rewriting multiple times. Fixes #1381 Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io> (cherry picked from commit e013bfd)
jarifibrahim
requested review from
ashish-goswami,
manishrjain and
a team
as code owners
jarifibrahim
changed the title
NamanJain8
approved these changes
Sep 9, 2020
mYmNeo
pushed a commit
to mYmNeo/badger
that referenced
this pull request
Jan 16, 2023
Fixes three issues with the current implementation: - It can generate compaction requests that break the invariant that bottom tables need to be consecutive (issue hypermodeinc#1380). See hypermodeinc#1380 (comment) - It performs the same level compactions in increasing order of levels (starting from L0) which leads to old versions of keys for the prefix re-surfacing to active transactions. - When you have to drop multiple prefixes, the API forces you to drop one prefix at a time and go through the whole expensive table rewriting multiple times. Fixes hypermodeinc#1381 Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io> (cherry picked from commit e013bfd) Co-authored-by: Damien Tournoud <damien@platform.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes three issues with the current implementation:
tables need to be consecutive (issue DropPrefix breaks levels, resulting in hard crashes and data loss #1380). See
DropPrefix breaks levels, resulting in hard crashes and data loss #1380 (comment)
(starting from L0) which leads to old versions of keys for the prefix
re-surfacing to active transactions.
prefix at a time and go through the whole expensive table rewriting multiple
times.
Fixes #1381
Co-authored-by: Ibrahim Jarif ibrahim@dgraph.io
(cherry picked from commit e013bfd)
This change is