-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CI): fix test suite and add CI steps #1808
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrdgraph
reviewed
Oct 13, 2022
skrdgraph
reviewed
Oct 13, 2022
skrdgraph
reviewed
Oct 13, 2022
repoint the merge into from |
joshua-goldstein
force-pushed
the
joshua/run-ci-jobs
branch
from
October 13, 2022 18:46
9e1b799
to
e4bddff
Compare
joshua-goldstein
requested review from
akon-dey,
gcxml and
billprovince
as code owners
October 13, 2022 18:46
skrdgraph
approved these changes
Oct 13, 2022
joshua-goldstein
added a commit
that referenced
this pull request
Feb 9, 2023
mangalaman93
pushed a commit
that referenced
this pull request
Feb 11, 2023
mangalaman93
pushed a commit
that referenced
this pull request
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Badger tests are run through a bash script called test.sh. It is currently not working, and there are no CI workflows on the Badger repository.
Solution
We update test.sh and add CI workflow steps. Test suite now works for Linux and Mac (x86, M1). To run the test suite, simply run
make test
. If you are on Mac, see remark below.Why a Makefile?
Badger depends on jemalloc for efficient memory allocation (see here, and z package in Ristretto). While Badger can be built without jemalloc, many users will probably want to benefit from it. The makefile makes it easy to install the jemalloc dependency with
make jemalloc
. Also now the test.sh script contains only test related functionality.This also has the advantage that now the CI workflow only needs essentially two steps:
Remarks
go get
is deprecated as a way to retrieve and install an executable into our $GOBIN, which is what we want to do here. We usego install
instead.mktemp
command, which is used in the test suite. In order to get the GNU version of this tool, you can run:This will temporarily modify your path so that the GNU version of mktemp is called in the script. Without this fix the script will complain that it doesn't recognize the p flag in
mktemp -d -p .
To-do