Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/wasi: regenerate WASI 0.2 bindings with explicit lift/lower code #16

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

ydnar
Copy link
Collaborator

@ydnar ydnar commented Jun 23, 2024

This PR implements the Canonical ABI lift and lower code explicitly in generated Go bindings for WASI / WIT.

It also restricts the allowed types in WebAssembly calls (wasmimport / wasmexport) to reflect the Go proposal at golang/go#66984, with the exception of the check for structs.HostLayout.

@ydnar ydnar self-assigned this Jun 23, 2024
This reflects the relaxed type restrictions proposed here (except for structs.HostLayout):
golang/go#66984
@ydnar ydnar marked this pull request as ready for review June 23, 2024 19:50
Copy link
Owner

@dgryski dgryski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@dgryski dgryski merged commit 11a6e1d into dgryski:dgryski/wasi-preview-2 Jun 24, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants