Skip to content

Commit

Permalink
fix: strip comments from processed styles (#512)
Browse files Browse the repository at this point in the history
Fixes #503
  • Loading branch information
petersandor authored and dherges committed Jan 19, 2018
1 parent d4bc66f commit 542aed2
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 1 deletion.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
"jasmine": "^2.6.0",
"json-schema-to-typescript": "^5.0.0",
"mocha": "^5.0.0",
"postcss-discard-comments": "^2.0.4",
"prettier": "^1.10.2",
"pretty-quick": "^1.2.1",
"react": "^16.0.0",
Expand Down
6 changes: 5 additions & 1 deletion src/lib/steps/assets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import * as nodeSassTildeImporter from 'node-sass-tilde-importer';
import * as less from 'less';
import * as stylus from 'stylus';
import * as postcssUrl from 'postcss-url';
import * as postcssComments from 'postcss-discard-comments';

export const processAssets: BuildStep =
async ({ artefacts, entryPoint, pkg }): Promise<NgArtefacts> => {
Expand Down Expand Up @@ -85,7 +86,10 @@ const processStylesheet =

if (cssUrl !== CssUrl.none) {
log.debug(`postcssUrl: ${cssUrl}`);
postCssPlugins.push(postcssUrl({ url: cssUrl }));
postCssPlugins.push(
postcssUrl({ url: cssUrl }),
postcssComments({ removeAll: true })
);
}
const result: postcss.Result = await postcss(postCssPlugins)
.process(cssStyles, {
Expand Down
29 changes: 29 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1648,6 +1648,10 @@ has-ansi@^2.0.0:
dependencies:
ansi-regex "^2.0.0"

has-flag@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/has-flag/-/has-flag-1.0.0.tgz#9d9e793165ce017a00f00418c43f942a7b1d11fa"

has-flag@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/has-flag/-/has-flag-2.0.0.tgz#e8207af1cc7b30d446cc70b734b5e8be18f88d51"
Expand Down Expand Up @@ -1951,6 +1955,10 @@ js-base64@^2.1.8:
version "2.4.0"
resolved "https://registry.yarnpkg.com/js-base64/-/js-base64-2.4.0.tgz#9e566fee624751a1d720c966cd6226d29d4025aa"

js-base64@^2.1.9:
version "2.4.1"
resolved "https://registry.yarnpkg.com/js-base64/-/js-base64-2.4.1.tgz#e02813181cd53002888e918935467acb2910e596"

js-tokens@^3.0.0:
version "3.0.2"
resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-3.0.2.tgz#9866df395102130e38f7f996bceb65443209c25b"
Expand Down Expand Up @@ -2689,6 +2697,12 @@ pinkie@^2.0.0:
version "2.0.4"
resolved "https://registry.yarnpkg.com/pinkie/-/pinkie-2.0.4.tgz#72556b80cfa0d48a974e80e77248e80ed4f7f870"

postcss-discard-comments@^2.0.4:
version "2.0.4"
resolved "https://registry.yarnpkg.com/postcss-discard-comments/-/postcss-discard-comments-2.0.4.tgz#befe89fafd5b3dace5ccce51b76b81514be00e3d"
dependencies:
postcss "^5.0.14"

postcss-url@^7.3.0:
version "7.3.0"
resolved "https://registry.yarnpkg.com/postcss-url/-/postcss-url-7.3.0.tgz#cf2f45e06743cf43cfea25309f81cbc003dc783f"
Expand All @@ -2703,6 +2717,15 @@ postcss-value-parser@^3.2.3:
version "3.3.0"
resolved "https://registry.yarnpkg.com/postcss-value-parser/-/postcss-value-parser-3.3.0.tgz#87f38f9f18f774a4ab4c8a232f5c5ce8872a9d15"

postcss@^5.0.14:
version "5.2.18"
resolved "https://registry.yarnpkg.com/postcss/-/postcss-5.2.18.tgz#badfa1497d46244f6390f58b319830d9107853c5"
dependencies:
chalk "^1.1.3"
js-base64 "^2.1.9"
source-map "^0.5.6"
supports-color "^3.2.3"

postcss@^6.0.1, postcss@^6.0.14, postcss@^6.0.2:
version "6.0.14"
resolved "https://registry.yarnpkg.com/postcss/-/postcss-6.0.14.tgz#5534c72114739e75d0afcf017db853099f562885"
Expand Down Expand Up @@ -3399,6 +3422,12 @@ supports-color@^2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/supports-color/-/supports-color-2.0.0.tgz#535d045ce6b6363fa40117084629995e9df324c7"

supports-color@^3.2.3:
version "3.2.3"
resolved "https://registry.yarnpkg.com/supports-color/-/supports-color-3.2.3.tgz#65ac0504b3954171d8a64946b2ae3cbb8a5f54f6"
dependencies:
has-flag "^1.0.0"

supports-color@^4.0.0, supports-color@^4.4.0:
version "4.5.0"
resolved "https://registry.yarnpkg.com/supports-color/-/supports-color-4.5.0.tgz#be7a0de484dec5c5cddf8b3d59125044912f635b"
Expand Down

0 comments on commit 542aed2

Please sign in to comment.