Skip to content

Commit

Permalink
fix: report ngc compiler diagnostics and throw an error (#292)
Browse files Browse the repository at this point in the history
  • Loading branch information
crowmagnumb authored and dherges committed Nov 17, 2017
1 parent 1a42ce1 commit 815509b
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions src/lib/steps/ngc.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as fs from 'fs';
import * as path from 'path';
import { performCompilation, readConfiguration, AngularCompilerOptions } from '@angular/compiler-cli';
import { performCompilation, readConfiguration, AngularCompilerOptions, exitCodeFromResult, formatDiagnostics } from '@angular/compiler-cli';
import { NgPackageData } from '../model/ng-package-data';
import { readJson, writeJson } from 'fs-extra';
import { debug } from '../util/log';
Expand All @@ -25,7 +26,6 @@ async function prepareTsConfig(ngPkg: NgPackageData, outFile: string): Promise<v
await writeJson(outFile, tsConfig);
}


/**
* Compiles typescript sources with 'ngc'.
*
Expand All @@ -40,7 +40,12 @@ export async function ngc(ngPkg: NgPackageData, basePath: string): Promise<strin

// invoke ngc programmatic API
const compilerConfig = readConfiguration(tsConfigPath);
performCompilation(compilerConfig);
const compilerResult = performCompilation(compilerConfig);

const exitCode = exitCodeFromResult(compilerResult.diagnostics);
if (exitCode !== 0) {
throw new Error(formatDiagnostics(compilerResult.diagnostics));
}

debug('Reading tsconfig from ' + tsConfigPath);
const tsConfig = await readJson(tsConfigPath);
Expand Down

0 comments on commit 815509b

Please sign in to comment.