fix: remove moduleId from rollup bundle options (#444)

Required change for rollup 0.53
ng-packagr · Dec 25, 2017 · da332d2 · da332d2
1 parent da7f073
commit da332d2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/lib/steps/rollup.spec.ts b/src/lib/steps/rollup.spec.ts
@@ -3,7 +3,7 @@ import { externalModuleIdStrategy, umdModuleIdStrategy } from './rollup';
 
 describe('rollup', () => {
 
-  describe(externalModuleIdStrategy.name, () => {
+  describe(`externalModuleIdStrategy`, () => {
     it(`should return 'false' paths starting with '.'`, () => {
       expect(externalModuleIdStrategy('./foo/bar')).to.be.false;
     });
@@ -34,7 +34,7 @@ describe('rollup', () => {
 
   });
 
-  describe(umdModuleIdStrategy.name, () => {
+  describe(`umdModuleIdStrategy`, () => {
     it(`should map 'rxjs/add/observable/bindCallback' to 'Rx.Observable'`, () => {
       expect(umdModuleIdStrategy('rxjs/add/observable/bindCallback')).to.equal('Rx.Observable');
     });

diff --git a/src/lib/steps/rollup.ts b/src/lib/steps/rollup.ts
@@ -102,8 +102,6 @@ export async function rollup(opts: RollupOptions): Promise<void> {
 
   // Output the bundle to disk
   await bundle.write({
-    // Keep the moduleId empty because we don't want to force developers to a specific moduleId.
-    moduleId: '',
     name: `${opts.moduleName}`,
     file: opts.dest,
     format: opts.format,