feat: remove unused dependencies and update peerDependencies

[alan-agius4]

I'm submitting a...

[ ] Bug Fix
[x] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

• Commit Messages follow the Conventional Commits pattern
  • A feature commit message is prefixed "feat:"
  • A bugfix commit message is prefixed "fix:"
• Tests for the changes have been added

Description

• removed lodash, glob and read-file from dependencies
• removed @types/glob, @types/lodash from devDependencies
• bumped @angular/cdk, tsickle and typescript
• updated peerDependencies tsickle to ^0.25.0 and typescript to >=2.4.2 <2.6

Does this PR introduce a breaking change?

[ ] Yes
[x] No

[dherges]

But glob is being used?

https://github.com/dherges/ng-packagr/blob/master/src/lib/steps/init.ts#L3

[alan-agius4]

good spot, fixed

[dherges]

peerDep: tsickle: ^0.24.0 – aligned with @angular/compiler-cli: ^5.0.0

[dherges]

see https://github.com/angular/angular/blob/5.0.0/packages/compiler-cli/package.json#L14

[alan-agius4]

But for angular 5.1.x its 0.25.5 https://github.com/angular/compiler-cli-builds/blob/master/package.json So probably it should be ‘>=0.24 <0.26’

…

On Sat, 09 Dec 2017 at 17:45, David Herges ***@***.***> wrote: see https://github.com/angular/angular/blob/5.0.0/packages/compiler-cli/package.json#L14 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#387 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQv-WlXd3I8Ox1_uJ1gJmekw1Hanl00vks5s-rlGgaJpZM4Q8Biy> .

[dherges]

I think it's ok with the "^0.25.0"

[alan-agius4]

Okay i’ll update it soon

[dherges]

Sorry, meant ^0.24.0 ➡️ People on 5.0.x use compiler-cli: ~5.0.0 and tsickle: >=0.24.0 <0.3.0 and people on 5.1.x use compiler-cli: ~5.1.0 and tsickle: ^0.25.5

[alan-agius4]

Bur when you specify ^0.24.0 it means ~0.24.X do its not correct

Since there is no major verion of tsickle npm treats ^ as ~

http://semver.org/

[alan-agius4]

Take a look here: http://jubianchi.github.io/semver-check/ ^0.24.0 is a range (caret) constraint. It means that it will match several versions. In fact, the current constraint will be satisfied by any version matching >=0.24.0 <0.25.0.

…

On Sat, 09 Dec 2017 at 18:32, David Herges ***@***.***> wrote: Sorry, meant ^0.24.0 ➡️ People on 5.0.x use compiler-cli: ~5.0.0 and tsickle: >=0.24.0 <0.3.0 and people on 5.1.x use compiler-cli: ~5.1.0 and tsickle: ^0.25.5 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#387 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQv-Wk9hFEZvSi7FXLdPTzEYomI9NL6fks5s-sQ3gaJpZM4Q8Biy> .

[dherges]

Ok, then it should be tsickle: ">=0.24.0 <0.26.0" right?

[alan-agius4]

Yes :) sry for the whole back and forth

…

On Sat, 09 Dec 2017 at 19:23, David Herges ***@***.***> wrote: Ok, then it should be tsickle: ">=0.24.0 <0.26.0" right? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#387 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQv-Wuv0Wr2JdLtEGYf64aCqaaSL2Bxtks5s-tARgaJpZM4Q8Biy> .

[github-actions]

This PR has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

_{This action has been performed automatically by a bot.}