Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recognize aliased and namespace decorator imports #585

Merged
merged 1 commit into from
Feb 4, 2018

Conversation

dherges
Copy link
Contributor

@dherges dherges commented Feb 4, 2018

I'm submitting a...

[x] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

Recognize component decorator metadata for named, aliased imports and namespace imports.

Usage Examples:

import { Component as Foo } from '@angular/core';

@Foo({
  selector: 'foo',
  template: `<h1>He yo, I am from a named, aliased import</h1>`
})
export class FooComponent {}
import * as ngCore from '@angular/core';

@ngCore.Component({
  selector: 'foo',
  template: `<h1>He yo, I am from a namespace import</h1>`
})
export class FooComponent {}

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@dherges dherges merged commit 8f88c5a into master Feb 4, 2018
@dherges dherges deleted the fix-imports branch February 4, 2018 15:49
@github-actions
Copy link

This PR has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

This action has been performed automatically by a bot.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant