fix: use correct aggregation type if numberType undefined (DHIS2-15698) #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numberType can be missing in AO that use the default value for it. The default value is VALUE and should not cause the total aggregation type to be overridden.
janhenrikoverland
approved these changes
Aug 15, 2023
dhis2-bot
added a commit
that referenced
this pull request
Aug 28, 2023
## [26.0.17](v26.0.16...v26.0.17) (2023-08-28) ### Bug Fixes * use correct aggregation type if numberType undefined DHIS2-15698 ([#1564](#1564)) ([c740e32](c740e32))
|
🎉 This PR is included in version 26.0.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janhenrikoverland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-15698
Key features
Description
The issue is a check in the PT engine on
numberType.Old saved AO do not necessarily have
numberTypereturned if the value matches the default.Because of that check in the PT engine, in that case a total aggregation type override variable is set to be
SUMand that is what causes the subtotals/totals to be the sum of the column/row values.Once Update is clicked, the app takes all the options from the Options modal and use those to control the table output.
At this point,
numberTypeis set toVALUE(which is also the default) and the override for the aggregation type is not set,AVERAGEis then used and the subtotals/totals are correct.The fix is about not overriding the aggregation type variable when no
numberTypeis present, which is equivalent to havenumberTypeset to its default value ofVALUE.Screenshots
numberTypeoption in DV:Before the fix, loading an AO does not respect the total aggregation type:
After the fix, loading the AO uses the correct aggregation type:
