fix: break version sentences [HUB-150] #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Birkbjo
approved these changes
Nov 29, 2022
dhis2-bot
added a commit
that referenced
this pull request
Nov 30, 2022
## [2.31.4](v2.31.3...v2.31.4) (2022-11-30) ### Bug Fixes * break version sentences [HUB-150] ([#700](#700)) ([e59bd4e](e59bd4e))
|
🎉 This PR is included in version 2.31.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
I removed the max-width on the text because it seems like it will not overflow the button length that much in most cases (and the button width would be language dependent if we internationalized in the future). If we keep the max-width, the second sentence in this example
Compatible with DHIS2 3.33 and above.would have been on two lines, which I thought looked a bit odder.