feat: app override initial support

[amcgee]

Requires dhis2/dhis2-core#5977

This adds a noticebox if an app is found on the App Hub with:

1. The name App Management
2. The developer organization DHIS2 (should probably be UiO or maybe an org just for UiO core apps?)
3. A version higher than the version of the current app

This is the noticebox in action. Clicking the link will install the app from the App Hub and then reload the page. @cooper-joe any feedback on messaging? The nice thing here is that we can update this after the 2.35 release, using this feature!!

This also adds a CORE APP indicator to any installed app which is overriding a bundled application (see screenshot)

[Birkbjo]

LGTM, just some minor comments.

[cooper-joe]

Looking good 👍 I think we could adjust the messaging to make it clear what will happen:

Clicking the link will install the app from the App Hub and then reload the page.

I think the button should read "Update and reload app", just to make it completely clear that clicking that button will refresh the page and potentially remove any inputs/changes the user has not committed. Perhaps we'd catch this with a dialog anyway? But either way, I think it's good to put it up front in the button.

[Philip-Larsen-Donnelly]

Very nice @amcgee !

Regarding point 2 in your note above, I agree that we should have a clear way of distinguishing core apps on the App Hub. Having a specific organisation could work, though it feels a bit hacky. I feel like it would be better to have a specific attribute - but, of course, the dhis2 organisation, or admin, should be the only one that can set that attribute.

I like the CORE APP indicator, but I wonder if we should be more explicit that it is a "CORE APP OVERRIDE"? However, I don't like the latter very much. Maybe we eventually need to add the info about which version is overridden, like:
CORE APP v31.0.0 (overrides bundled version v29.5.0)
But I think as it is is fine for the release

[amcgee]

Having a specific organisation could work, though it feels a bit hacky.

Maybe, but it does do exactly what we want - only developers we explicitly grant access can push to an organization we own. That's basically the "specific attribute" but using a system we already have in place. Is there a reason to require a separate attribute?

I like the CORE APP indicator, but I wonder if we should be more explicit that it is a "CORE APP OVERRIDE"? However, I don't like the latter very much. Maybe we eventually need to add the info about which version is overridden, like:
CORE APP v31.0.0 (overrides bundled version v29.5.0)
But I think as it is is fine for the release

I agree the UI could be improved, but I don't think we actually want to specify that these are "overrides" - they are just core apps which have been upgraded. Eventually we should have a "Core Apps" section of this app which includes all bundled and overridden apps, has buttons to update each one if an update exists, and allows "rollback" to the bundled version in exceptional circumstances. But I think that's out of scope of this change - we can push that update to App Management once we have this self-update mechanism in place.

[Birkbjo]

Having a specific organisation could work, though it feels a bit hacky.

Maybe, but it does do exactly what we want - only developers we explicitly grant access can push to an organization we own. That's basically the "specific attribute" but using a system we already have in place. Is there a reason to require a separate attribute?

I've also thought about this, and I think I agree on having something like DHIS2 Core as an organisation for these apps. In addition to the authority-system you mention, it would also mean we could use existing filtering on both the client and server without introducing a new concept/attribute and functionality for that.

[amcgee]

@cooper-joe updated the wording of the button

There's a live demo here http://d2.winged.tech:8080/dhis-web-app-management/index.html

Note that the version is artificially set to always show the banner, but when the version of the current app is <= the highest compatible version on the App Hub it will disappear

[Philip-Larsen-Donnelly]

OK. Agreed w.r.t. having core organisation, and also that CORE APPS are not always "overrides".

[cooper-joe]

LGTM 👍

[dhis2-bot]

🎉 This PR is included in version 28.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀