-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DHIS2-13294): add link to navigate to app after install #555
Conversation
🚀 Deployed on https://pr-555--dhis2-app-management.netlify.app |
5f3415b
to
430e3ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM!
@cooper-joe is the UX for this ok with you? I labelled the button "Go to app" .. but it's actually "go to app page in app management" rather than going to the actual app. I can't think of a good way to distinguish the two (we'll be adding a link to go the actual app from the app details page) |
A label like "View app details" here is a bit less concise, but it is clearer where it is taking the user. In the future the link to the actual app on the app management page could have a label like "Open app". |
a91aa36
to
3d6b6d7
Compare
Head branch was modified
3d6b6d7
to
65693c8
Compare
## [100.2.36](v100.2.35...v100.2.36) (2024-09-11) ### Bug Fixes * **DHIS2-13294:** add link to navigate to app after install ([#555](#555)) ([27e157a](27e157a))
🎉 This PR is included in version 100.2.36 🎉 The release is available on: Your semantic-release bot 📦🚀 |
part of the fix for DHIS2-13294 - depends on dhis2/dhis2-core#18454
Adds a link to navigate to the installed app on success.