Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: opt-in git hooks #333

Merged
merged 5 commits into from
Dec 16, 2020
Merged

feat: opt-in git hooks #333

merged 5 commits into from
Dec 16, 2020

Conversation

varl
Copy link
Contributor

@varl varl commented Dec 16, 2020

  • chore: add config for commit-msg hook
  • fix: make hook suitable for other repos
  • feat: opt-in to use git-hooks with install

It is possible to install all available git hooks with:

    d2-style install git-hooks/all

Or specific hooks with e.g.

    d2-style install git-hooks/commit-msg
@varl varl changed the base branch from master to alpha December 16, 2020 13:55
@varl varl changed the title optin hooks feat: opt-in git hooks Dec 16, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@varl varl merged commit a3bc415 into alpha Dec 16, 2020
@varl varl deleted the optin-hooks branch December 16, 2020 14:02
dhis2-bot added a commit that referenced this pull request Dec 16, 2020
# [8.0.0-alpha.2](v8.0.0-alpha.1...v8.0.0-alpha.2) (2020-12-16)

### Features

* opt-in git hooks ([#333](#333)) ([a3bc415](a3bc415))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 8.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

varl added a commit that referenced this pull request Mar 26, 2021
It is possible to install all available git hooks with:

    d2-style install git-hooks/all

Or specific hooks with e.g.

    d2-style install git-hooks/commit-msg
varl pushed a commit that referenced this pull request Mar 26, 2021
varl pushed a commit that referenced this pull request Mar 26, 2021
dhis2-bot added a commit that referenced this pull request May 5, 2021
# [8.0.0](v7.3.0...v8.0.0) (2021-05-05)

### Bug Fixes

* allow eslint to print colors ([#384](#384)) ([c95a184](c95a184))
* ignore .d2 directory ([#386](#386)) ([6a473f2](6a473f2))
* match files from project root ([b77ef35](b77ef35))
* wrong hooks where installed by default ([#385](#385)) ([3ac82f4](3ac82f4))

### Code Refactoring

* remove husky ([752b944](752b944))

### Features

* commit check can read from a custom file ([366be0c](366be0c))
* delete deprecated configuration files ([c961647](c961647))
* lint file system for consistent names ([#379](#379)) ([2bfb5ef](2bfb5ef))
* new and improved d2-style ([#378](#378)) ([f8279e5](f8279e5))
* opt-in git hooks ([#333](#333)) ([a3bc415](a3bc415))
* show eslint warnings ([#368](#368)) ([abe4668](abe4668))

### BREAKING CHANGES

* The verb (check/apply) is now moved to the top-level.  E.g.
"d2-style js check" becomes "d2-style check js". This is to allow all checkers
to run with a single command: "d2-style check"
* "d2-style install" is no longer used to set up linters.  As of
husky@5 the tool is vastly simplified and much faster. Hooks can be installed
manually with "d2-style install", but is also run as a "post-install" script
that we control for consistency. Configuration is added to the project with the
"d2-style add" command.
* Husky has been removed from cli-style. You will need to
remove hooks that reference husky.sh in .git/hooks.
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants