Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export configs from package #93

Merged
merged 7 commits into from
Jul 15, 2019
Merged

feat: export configs from package #93

merged 7 commits into from
Jul 15, 2019

Conversation

varl
Copy link
Contributor

@varl varl commented Jul 15, 2019 •
edited
Loading

Implemented your suggestion, @ismay. It could look something like this.

@varl varl requested a review from ismay July 15, 2019 09:49
@varl varl mentioned this pull request Jul 15, 2019
Merged
@varl
Copy link
Contributor Author

varl commented Jul 15, 2019

This is going to break the way CLI imports the tool: https://github.com/dhis2/cli/blob/master/packages/main/src/index.js#L9

@varl varl mentioned this pull request Jul 15, 2019
Closed
@varl varl requested a review from Mohammer5 July 15, 2019 10:59
@ismay
Copy link
Contributor

ismay commented Jul 15, 2019

This is going to break the way CLI imports the tool

Ah, hmm. Is that fixable?

Mohammer5
Mohammer5 reviewed Jul 15, 2019
View reviewed changes
Copy link
Contributor

@Mohammer5 Mohammer5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to break the way CLI imports the tool:

command.config = configObject()
command.command = command
module.exports = command

It's self referencing.. But at least it's backwards compatible for the time being?

src/groups.js Outdated Show resolved Hide resolved
@varl
Copy link
Contributor Author

varl commented Jul 15, 2019

Ah, hmm. Is that fixable?

Yeah, it's a trivial fix: yargs.command(require('@dhis2/cli-style').command)

Mohammer5
Mohammer5 approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@Mohammer5 Mohammer5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@varl varl merged commit 55fd0f9 into master Jul 15, 2019
ismay
ismay reviewed Jul 15, 2019
View reviewed changes
.huskyrc.js Show resolved Hide resolved
dhis2-bot pushed a commit that referenced this pull request Jul 15, 2019
chore(release): cut 4.1.0 [skip ci]
7e94738 
# [4.1.0](v4.0.0...v4.1.0) (2019-07-15)

### Features

* export configs from package ([#93](#93)) ([55fd0f9](55fd0f9))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@varl varl deleted the export-configs branch July 15, 2019 13:43
@varl varl restored the export-configs branch July 21, 2019 15:10
@varl varl deleted the export-configs branch October 28, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismay ismay ismay left review comments

@Mohammer5 Mohammer5 Mohammer5 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@varl @ismay @dhis2-bot @Mohammer5