Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable ou tree and levels/groups with user orgunits and display decent title #3241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

janhenrikoverland
Copy link
Collaborator

@janhenrikoverland janhenrikoverland commented Oct 10, 2024

Implements DHIS2-18066

Requires dhis2/analytics#1702


TODO

  • Manual testing

Screenshots

See dhis2/analytics#1702

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-3241.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify October 10, 2024 09:56 Inactive
@jenniferarnesen jenniferarnesen added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Oct 10, 2024
Copy link

cypress bot commented Oct 10, 2024

Data Visualizer App    Run #2941

Run Properties:  status check failed Failed #2941  •  git commit 5fd30ef0f9 ℹ️: Merge d3be17d569203a96264c6a7c9c909bea73e9ec9e into 04dee94d3b42cb2ec2f592c42967...
Project Data Visualizer App
Run status status check failed Failed #2941
Run duration 12m 17s
Commit git commit 5fd30ef0f9 ℹ️: Merge d3be17d569203a96264c6a7c9c909bea73e9ec9e into 04dee94d3b42cb2ec2f592c42967...
Committer Jan Henrik Øverland
View all properties for this run ↗︎

Test results
Tests that failed  Failures 19
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 703

Tests for review

Failed  dimensions/orgUnit.cy.js • 9 failed tests • e2e-chrome-parallel-2.41-1

View Output Video

Test Artifacts
Org unit dimension > selects a district level org unit - Bo Test Replay Screenshots Video
Org unit dimension > selects a chiefdom level org unit - Biriwa in Bombali Test Replay Screenshots Video
Org unit dimension > deselects Bo and Biriwa Test Replay Screenshots Video
Org unit dimension > selects a level - District Test Replay Screenshots Video
Org unit dimension > deselects District Test Replay Screenshots Video
Org unit dimension > selects a group - Eastern Area Test Replay Screenshots Video
Org unit dimension > deselects Eastern Area Test Replay Screenshots Video
Org unit dimension > selects a user org unit - 'User sub-units' Test Replay Screenshots Video
Org unit dimension > deselects 'User sub-units' Test Replay Screenshots Video
Failed  dimensions/orgUnit.cy.js • 9 failed tests • e2e-chrome-parallel-2.40-1

View Output Video

Test Artifacts
Org unit dimension > selects a district level org unit - Bo Test Replay Screenshots Video
Org unit dimension > selects a chiefdom level org unit - Biriwa in Bombali Test Replay Screenshots Video
Org unit dimension > deselects Bo and Biriwa Test Replay Screenshots Video
Org unit dimension > selects a level - District Test Replay Screenshots Video
Org unit dimension > deselects District Test Replay Screenshots Video
Org unit dimension > selects a group - Eastern Area Test Replay Screenshots Video
Org unit dimension > deselects Eastern Area Test Replay Screenshots Video
Org unit dimension > selects a user org unit - 'User sub-units' Test Replay Screenshots Video
Org unit dimension > deselects 'User sub-units' Test Replay Screenshots Video
Failed  visTypes/outlierTable.cy.js • 1 failed test • e2e-chrome-parallel-2.41-3

View Output Video

Test Artifacts
using an Outlier table visualization > creates, edits, saves it correctly Test Replay Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants