Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: obtain datastore values directly instead of from metadata #57

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

mediremi
Copy link
Contributor

@mediremi mediremi commented May 27, 2021

Closes https://jira.dhis2.org/browse/DHIS2-10794.

The namespace protection introduced by dhis2/dhis2-core#7520 has changed the schema for /api/dataStore/<namespace>/<key>/metaData. The result of that API no longer has the value field that the datastore app expects.

@mediremi mediremi requested a review from Birkbjo May 27, 2021 15:08
Copy link
Member

@Birkbjo Birkbjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mediremi mediremi merged commit 749edd7 into master Jun 1, 2021
@mediremi mediremi deleted the fix/update-value-schema branch June 1, 2021 13:23
dhis2-bot added a commit that referenced this pull request Jun 1, 2021
## [1.3.3](v1.3.2...v1.3.3) (2021-06-01)

### Bug Fixes

* obtain datastore values directly instead of from metadata  ([#57](#57)) ([749edd7](749edd7))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.3.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants