fix: load EarthEngine directly from node_modules browser build #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turban
approved these changes
Apr 2, 2019
dhis2-bot
added a commit
that referenced
this pull request
Dec 10, 2020
# [31.1.0](v31.0.3...v31.1.0) (2020-12-10) ### Bug Fixes * fitbounds, on layergroup and in general ([0e83006](0e83006)) * load EarthEngine directly from node_modules browser build ([#50](#50)) ([020ea5f](020ea5f)) * override circle getBounds before map is bound ([#54](#54)) ([481c187](481c187)) * support index re-ordering ([20975bc](20975bc)) ### Features * event polygons ([#52](#52)) ([c2debad](c2debad)) * export map control types ([#74](#74)) ([71e597a](71e597a)) * export supported layer types ([#73](#73)) ([6bde95c](6bde95c)) * layer types as static method ([#66](#66)) ([bb124bf](bb124bf)) * support generic layer group ([89d9156](89d9156)) * synced maps support ([#58](#58)) ([0cd7eae](0cd7eae)) * synchronize the view of two maps ([#56](#56)) ([7dbffe3](7dbffe3)) * translate options to leaflet syntax ([#75](#75)) ([f1a3245](f1a3245))
|
🎉 This PR is included in version 31.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the issue here was with babel and webpack running on the closure-compiler-processed file we copied into src, but I managed to fix it just by directly loading the
ee_api_js.jsfile from the@google/earthenginepackage. This is the one built for browsers (the default export is built for npm).This fixes the error in DHIS2-6507 and allows EarthEngine layers to load both in plugins and in the main app.