fix: use custom locale when it exists #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mohammer5
approved these changes
Mar 9, 2023
kabaros
force-pushed
the
fix/custom-calendar-locale
branch
from
d579873 to
bc2233e
Compare
Mohammer5
approved these changes
Mar 9, 2023
dhis2-bot
added a commit
that referenced
this pull request
Mar 9, 2023
## [1.0.2](v1.0.1...v1.0.2) (2023-03-09) ### Bug Fixes * use custom locale when it exists ([#23](#23)) ([3cfb58a](3cfb58a))
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
ne-NP(nepali) calendar tests in dhis/ui broke after integrating the updated version of this library.The issue is caused by resolvedOptions overriding the custom locale based on the browser. There is a test for the scenario in this repo, but it passed because
ne-NPis a supported locale in node environments, but it's not on chromium-based browsers so it just defaulted to the user locale in that case. This change makes sure that, when we are providing our locale resources, then we always use them.related PR: dhis2/ui#1248