-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C4GT] Asset: Added test for InvalidAssetType Issue #374 #427
Conversation
Signed-off-by: hardik-pratap-singh <21bcs090@iiitdmj.ac.in>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hardik-pratap-singh Even though the tests have passed, I doubt that else branch is actually being executed.
Since initially asset type has been set to MF
. And in if condition it is being checked if type is of any 3 valid types. So if part is executed and not else.
So the error code is not being checked.
Please add a log and check.
@vatsa287 ! I was also thinking the same. But everywhere I can find asset_type being initialized with MF. How can I actually get the asset_type ? |
Check pallets/src/types.rs where we define
|
I wanted to ask that all of the values i.e. |
@vatsa287 Can you help me with it ? |
Hey @vatsa287 @NiranjanAP @amarts ! Can you please guide me ? |
@hardik-pratap-singh Regarding this, It is not possible to send a value/option which is not defined in the |
Fixes #374
Added tests for
InvalidAssetType
for pallet/asset@vatsa287 @amarts