HP Spinner on Mobile #167
Open
HP Spinner on Mobile #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhleong
force-pushed
the
dhleong/hp-slider
branch
2 times, most recently
from
7d61da3
to
ceff383
Compare
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/dhleong/wish/nd6gqdjkz |
dhleong
force-pushed
the
dhleong/hp-slider
branch
from
ceff383
to
3d67bb5
Compare
I think what we really need to do is actually map the touches to points on the circle and compute the arc length between them
This exposes an issue where the rotation amount changes quite drastically when going across the 9 o'clock angle...
Algorithm with thanks to my Flight Controls project!
dhleong
force-pushed
the
dhleong/hp-slider
branch
from
0678ace
to
d4b6cd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a more touch-centric UI for modifying HP when on mobile, allowing you to "scrub" through HP deltas to get to the number you want, rather than having to open the keyboard and type. This is somewhat like what D&DB has, but since it's circular (like a volume knob) it's easier to get to bigger numbers, while also maintaining precision.
Closes #162