36-feat-card-transactions

[parthux1]

closes #36

As of now the implementation writes Card payment information to the already generated CSV.

Polluted fields:

field	value
ID	generated as in other rows
Status	generated as in other rows
Timestamp	date of transaction
Type	Cash
Name	Beneficiary (name)
Debit	amount payed

whats missing for this PR to be closed (IMO)

• prevent log warnings for fields unique for card payment transactions
• tests
• map available IBAN letters to CSV (first 4 numbers are available)
• maybe append Readme
• validate detector (no data available for failed transactions from my side, marked as TODO in-code)

I hope I utilized the corresponding patterns correctly and sticked to your style. As it's my first time writing Go I'd be grateful if you comment if you see a problem with the used style&approaches.

[dhojayev]

Hey @parthux1 ,
It is so great to see the first external PR.
I would highly suggest to start with test data. If you need some help - I can help you.
With that you will adhere to TDD principles and would be able to simulate processing card transactions without needing real data from TR.
Some examples to start with are:

• https://github.com/dhojayev/traderepublic-portfolio-downloader/blob/4e6b4eb1498f1cb1872c3abf7f6f2d99dc56b36a/tests/fakes/card_successful_transaction_01.go
• https://github.com/dhojayev/traderepublic-portfolio-downloader/blob/4e6b4eb1498f1cb1872c3abf7f6f2d99dc56b36a/tests/fakes/card_successful_transaction_02.go

Test cases contain all responses and their "normalized" state. With that it will help both you and me to make sure that changes are working.

Again, if you need help, we can chat and I can help you setting it up.
Let me know.

[parthux1]

FYI; I'm currently moving. I'll implement your suggestions as soon as I'm done and have my new wifi.