Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolveNextVersion should provide bumpStrategy instead of releaseStrategy #69

Merged
merged 2 commits into from
Jul 9, 2021
Merged

resolveNextVersion should provide bumpStrategy instead of releaseStrategy #69

merged 2 commits into from
Jul 9, 2021

Conversation

zhbhun
Copy link

@zhbhun zhbhun commented Jul 8, 2021

resolveNextVersion(currentVersion, nextVersion, strategy = "override")'s strategy accept bump strategy: inherit, override, satisfy`, but getDependentRelease invoke resolveNextVersion with release strategy: patch, minor, major, inherit.

@antongolub
Copy link
Collaborator

antongolub commented Jul 8, 2021 •
edited
Loading

Hey, @zhbhun,

Good catch, thanks! Could you also:

  • rename fn param to clarify the passed strategy type: strategy = "override" → bumpStrategy = "override"
  • remove releaseStrategy arg from getDependentRelease(pkg, bumpStrategy, releaseStrategy, ignore). It seems useless after the fix.
    ?

@zhbhun
Copy link
Author

zhbhun commented Jul 9, 2021 •
edited
Loading

Sure!

  • strategy is rename to bumpStrategy.
  • releaseStrategy is used to resolveReleaseType that is called in getDependentRelease.

antongolub
antongolub approved these changes Jul 9, 2021
View reviewed changes
Copy link
Collaborator

@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antongolub antongolub merged commit ee2dee6 into dhoulb:master Jul 9, 2021
@antongolub
Copy link
Collaborator

Great. Thanks!

@antongolub
Copy link
Collaborator

🎉 This PR is included in version 2.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antongolub antongolub antongolub approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhbhun @antongolub