Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacements should not appear adjacent to each other #24

Open
Real-John-Cheung opened this issue Sep 19, 2021 · 0 comments
Open

Replacements should not appear adjacent to each other #24

Real-John-Cheung opened this issue Sep 19, 2021 · 0 comments
Labels
post-launch we can come back to this after first release
Milestone
Version 2.0

Comments

@Real-John-Cheung
Copy link
Collaborator

Real-John-Cheung commented Sep 19, 2021 •
edited by dhowe
Loading

In the case where two ads are vertically adjacent, and would both be replaced, instead only one should be replaced, and the other just hidden
@dhowe dhowe changed the title Replacements should not adjacent to each other Replacements should not be adjacent to each other Sep 19, 2021
@dhowe dhowe changed the title Replacements should not be adjacent to each other Replacements should not appear adjacent to each other Sep 19, 2021
@Real-John-Cheung Real-John-Cheung added the post-launch we can come back to this after first release label Oct 9, 2021
@dhowe dhowe added this to the v2.0 milestone Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
post-launch we can come back to this after first release
Projects
None yet
Milestone
Version 2.0
Development

No branches or pull requests
2 participants
@dhowe @Real-John-Cheung