Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty frame, dynamic filtering issue #1852

Closed
Snaxeko opened this issue May 30, 2021 · 7 comments
Closed

Empty frame, dynamic filtering issue #1852

Snaxeko opened this issue May 30, 2021 · 7 comments
Assignees
Labels
Milestone

Comments

@Snaxeko
Copy link

Snaxeko commented May 30, 2021

Describe the issue

Tested in a new Firefox profile. After clicking on µ/more/more, there should be this window every time I open the extension UI & click on "µ".
image

It works only 1 time.

No issue for µ/more/more/less (if I close the dynamic filtering setting)

Screenshot in which the issue can be seen

After that there's an empty frame (after clicking on "µ").
image

Steps for anyone to reproduce the issue

  1. Install Adnauseam
  2. Go to µ/more/more(/more eventually, same issue as long as there's the table)
  3. Close the Adnauseam window
  4. Go to "µ" again, observe an empty frame

Your settings

  • OS/version: Windows 10
  • Browser/version: Firefox 88.0.1
  • AdNauseam version: 3.10.4
  • Other extensions you have installed: No
  • AdNauseam settings: default settings, custom settings, I also tried to enable the 3 boxes.
Your filter lists

Default.

Your location/country

France

@Apep-the-snek
Copy link

Apep-the-snek commented Jun 7, 2021

This also happens on Librewolf after uninstalling uBlock Origin, Librewolf is essentially the same as firefox but with a bunch of settings changed for privacy.

@Apep-the-snek
Copy link

I found a shitty temporary fix: everytime you need that menu, if you just used it on the regular toolbar, put the AdNauseam icon in he overflow menu and use it from there, and vice versa.

@dhowe
Copy link
Owner

dhowe commented Jun 8, 2021

@mneunomne progress on this issue?

@mneunomne
Copy link
Collaborator

@dhowe I can confirm this issue is happening on firefox with Adn 3.10.4. But it seems to be related to this issue #1847 , I tested and it not happening anymore with merge 1.34.0.

@dhowe
Copy link
Owner

dhowe commented Jun 10, 2021

So this will be fixed in the next release, which should be in the next few days...

@mneunomne
Copy link
Collaborator

Yes, I still should run more tests related to this though.

@dhowe dhowe added this to the Version 3.11 milestone Jun 22, 2021
@mneunomne
Copy link
Collaborator

Tested, it seems to be working as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants