Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs on other locales #911

Closed
cqx931 opened this issue Mar 7, 2017 · 7 comments
Closed

Bugs on other locales #911

cqx931 opened this issue Mar 7, 2017 · 7 comments
Assignees

Comments

@cqx931
Copy link
Collaborator

cqx931 commented Mar 7, 2017

Chinese:(from Release 3.1.30)
1.First-run page, span tag
image

2.DNT Notification, undefined
3.Menu - Text ads layout
image

@cqx931 cqx931 self-assigned this Mar 7, 2017
@cqx931
Copy link
Collaborator Author

cqx931 commented Mar 7, 2017

4.adnauseam.txt is not loaded when default locale is Chinese
(new issue caused by the merge) This seems to be solved by now
image

@dhowe
Copy link
Owner

dhowe commented Mar 7, 2017

Good notice! Is this related to the merge, or a pre-existing problem?
We should make sure to test other locales regularly...

@cqx931
Copy link
Collaborator Author

cqx931 commented Mar 7, 2017

The first three problems should be pre-existing problem, starting from 3.1.30 in release versions, if ignoring the version bumps during development.
And the last one is caused by the latest merge.

@cqx931
Copy link
Collaborator Author

cqx931 commented Mar 10, 2017

The layout of the text ad in Chinese language setting seems to be caused by a design decision from chrome browser.
If the language is set to Chinese, the minimum font size is 12px.
And here we are setting the content of Text-ad to 10px...
One way to solve it is to set the hight of each text entry to 90px instead of 80px. But I'm not sure whether we want to do this due to this very minor case.
https://productforums.google.com/forum/#!topic/chrome/Q18nyAQimVo

@dhowe
Copy link
Owner

dhowe commented Mar 10, 2017

@mushon?

@cqx931
Copy link
Collaborator Author

cqx931 commented Mar 13, 2017

Fixed all above issues except the Chinese text-ad layout one:
#924

@dhowe
Copy link
Owner

dhowe commented Mar 13, 2017

Ok, closing (see #925 for Chinese text-ad layout issue)

@dhowe dhowe closed this as completed Mar 13, 2017
@cqx931 cqx931 mentioned this issue Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants