-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checkbox to "clear characters" on the jump event #1209
Comments
Wouldn't it be cleaner to implement a leave_all method on the Portraits subsystem? Because then you could very easily call it from outside as well (e.g. Dialogic.Portraits.leave_all()) or remove_all() alternatively. |
After considering it, maybe it is better that the user deals with clearing the screen if they want to. |
Yeah, I think it's a nice thing to have but not very important as a simple |
Yes! |
I think I'm against implementing this on the jump event. Because jumping does not at all need clearing most of the time. I'd rather consider a clear event that actually calls a version of Dialogic.clear() (without clearing timeline info and variables). |
A clear event seems like the best solution. That way we keep each event as minimal as possible. |
I'll close this in favor of #1699 |
add a checkbox to "clear characters" on the jump event. we don't want them always leaving because you may want to do a jump and preserve the character state, but optionally a cleanup step like that is handy
all the Leave actions are part of the Character event, rather than the Portrait Subsystem, so there's no direct way to call it there. but also because of that, would be super simple to implement, just needing a few lines at the beginning of Jump event's _execute():
The text was updated successfully, but these errors were encountered: