Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkbox to "clear characters" on the jump event #1209

Closed
ii4y-studios opened this issue Sep 2, 2022 · 7 comments
Closed

checkbox to "clear characters" on the jump event #1209

ii4y-studios opened this issue Sep 2, 2022 · 7 comments
Assignees

Comments

@ii4y-studios
Copy link
Collaborator

add a checkbox to "clear characters" on the jump event. we don't want them always leaving because you may want to do a jump and preserve the character state, but optionally a cleanup step like that is handy

all the Leave actions are part of the Character event, rather than the Portrait Subsystem, so there's no direct way to call it there. but also because of that, would be super simple to implement, just needing a few lines at the beginning of Jump event's _execute():

  • duplicate the Character event from the event cache
  • set it to ActionType.Leave
  • set _leave_all to true
  • _execute() it
  • then proceed with the rest of the jump
@Jowan-Spooner
Copy link
Collaborator

Wouldn't it be cleaner to implement a leave_all method on the Portraits subsystem? Because then you could very easily call it from outside as well (e.g. Dialogic.Portraits.leave_all()) or remove_all() alternatively.

@coppolaemilio
Copy link
Collaborator

After considering it, maybe it is better that the user deals with clearing the screen if they want to.

@Jowan-Spooner
Copy link
Collaborator

Yeah, I think it's a nice thing to have but not very important as a simple Leave --All-- before the jump or at the beginning of the next timeline does the same. Also if we add a clear option it should probably remove backgrounds, styling and music as well.

@coppolaemilio
Copy link
Collaborator

coppolaemilio commented Sep 2, 2022

Yes!
Reset the background, characters, music, swap to the default theme and... I can't think of anything else?

@Jowan-Spooner
Copy link
Collaborator

I think I'm against implementing this on the jump event. Because jumping does not at all need clearing most of the time. I'd rather consider a clear event that actually calls a version of Dialogic.clear() (without clearing timeline info and variables).

@coppolaemilio
Copy link
Collaborator

A clear event seems like the best solution. That way we keep each event as minimal as possible.

@Jowan-Spooner
Copy link
Collaborator

I'll close this in favor of #1699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants