Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the Character Name alignment whereever the character is.. #1285

Open
MecoCL opened this issue Nov 5, 2022 · 5 comments
Open

Changing the Character Name alignment whereever the character is.. #1285

MecoCL opened this issue Nov 5, 2022 · 5 comments
Assignees

Comments

@MecoCL
Copy link

MecoCL commented Nov 5, 2022

Hi, I was thinking it would be a great feature for Dialogic to have the Character's name's alignment changed where ever the character is, on the left, on the right, anywhere

Just like this.

vlcsnap-2022-11-05-19h43m15s580
vlcsnap-2022-11-05-19h43m22s595

@Jowan-Spooner
Copy link
Collaborator

The thing is that while I like the general idea, there is lots of things that are a bit unclear. Like, what happens for a character in the central position?

Personally I think for 2.x we should add a method to easily get lot's of information on the current speaker, so you can easily adapt your ui and also maybe a signal for speaker change.

@MecoCL
Copy link
Author

MecoCL commented Nov 5, 2022

What happens to Central position, like Middle alignment? well, just keep the text in the middle

@ii4y-studios
Copy link
Collaborator

and also maybe a signal for speaker change

is a signal for speaker change alrady! :) we could just add speaker position along with speaker name in the signal

@MecoCL
Copy link
Author

MecoCL commented Nov 5, 2022

I see, so this is confirmed for 2.X version?

@ii4y-studios ii4y-studios self-assigned this Nov 6, 2022
@ii4y-studios
Copy link
Collaborator

lol, heck its confirmed for sometime in the next week when I get chance to implement it :) (well, maybe, idk how much time I'll have in the next week)

so most of this, mind you, will be how you design your dialog scene to customize it to consume this data the way you need it, since character positions themselves in 2.0 arent left/center/right like they are in 1.x, but freely placable and address by numbers (and also maybe name in the future, thats in plans for something). there's already the Text.speaking_character(string) signal that's emitted on each Text event, sending either the name of the currently speaking character or '(Nobody)' if it's a dialogue without anyone speaking. I've used this in a test to be able to set the entire dialog box to match the character, having a scene with multiple characters each with a dialog box attrached to them over their head, and it would show the box of whoever was speaking

there aren't any signals in the Portrait subsystem right now, but I can add some signals for add/update/leave easily enough with the naem of the character and position theyre being put on. then you just have your dialog scene listen for those signals to keep track of who's where in the scene, and then when a speaking_character signal is emitted make it show/move the name box to whichever matching position you want form there.

Note to self: change speaking_character signal to also emit the selected portrait as well, in case anyone needs it for reasons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants