Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error occurs when using EndTimelineEvent while displaying a character on the timeline #1628

Closed
naonya3 opened this issue Jun 30, 2023 · 0 comments · Fixed by #1629
Closed
Labels
Bug 🐞 Something isn't working

Comments

@naonya3
Copy link
Contributor

naonya3 commented Jun 30, 2023

The problem

Describe the bug
Error occurs when using EndTimelineEvent while displaying a character on the timeline.

To Reproduce

  1. Join a character to the timeline
  2. Add End Timeline Event
  3. error Invalid call. Nonexistent function 'remove_portrait' in base 'Node (subsystem_portraits.gd)'.

Expected behavior
Resolving Errors.

Screenshots
image

System (please complete the following information):

  • OS: macOS
  • Godot Version: 4.1 RC1
  • Dialogic Version: [2.0] (984bcb7)

Solutions

Workaround
///

Possible fixes

Probably a mistake in the method to call.
The following changes should fix it Create a PR later.

dialogic.Portraits.remove_portrait(character)
https://github.com/coppolaemilio/dialogic/blob/984bcb75213f265c440cf6894c9b2446525889b3/addons/dialogic/Modules/End/event_end.gd#L14C4-L14C4

to

dialogic.Portraits.remove_character(character)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants