Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifying Files does not enable Begin Conversion #1715

Closed
mechPenSketch opened this issue Sep 10, 2023 · 2 comments
Closed

Verifying Files does not enable Begin Conversion #1715

mechPenSketch opened this issue Sep 10, 2023 · 2 comments

Comments

@mechPenSketch
Copy link
Contributor

mechPenSketch commented Sep 10, 2023

The problem

Describe the bug
I can't begin the conversion even after verifying the files

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Dialogic Workspace
  2. Got to Settings > Features > Converter
  3. Click 'Verify Files'. Folder converted-dialogic should then appear in res://.

Expected behavior
For the 'Begin Conversion' to then be enabled.

Screenshots
dialogic

System (please complete the following information):

  • OS: Windows 10
  • Godot Version: v4.1.stable.official [970459615]
  • Dialogic Version: 2.0-Alpha-9

Solutions

Workaround
I'll fix the code directly.

Possible fixes
I'll look at res://addons/dialogic/Modules/Converter/settings_converter.gd first.

It looks like on res://addons/dialogic/Modules/Converter/settings_converter.tscn, the node RightPanel has HBox as its parent and not Converter.
I've posted my fixes on #1716.

@Jowan-Spooner
Copy link
Collaborator

I've merged #1716. Should I close this issue?

@mechPenSketch
Copy link
Contributor Author

I'll close this now that it's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants