Fix for slice_experiments if image_range != (1,N) #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gorilla of temporary workarounds for inconsistent scan and imageset slicing (cctbx/dxtbx#213). Fixes #1382
rjgildea
added a commit
to xia2/xia2
that referenced
this pull request
Aug 26, 2020
Apparently expt.imageset.get_scan() is a different scan instance to expt.scan. As highlighted by dials/dials#1383 it it necessary to ensure that both scan objects have the same batch_offset.
Codecov Report
@@ Coverage Diff @@
## master #1383 +/- ##
==========================================
- Coverage 64.61% 64.60% -0.01%
==========================================
Files 615 615
Lines 69872 69871 -1
Branches 9547 9547
==========================================
- Hits 45145 45143 -2
Misses 22953 22953
- Partials 1774 1775 +1 |
rjgildea
added a commit
to xia2/xia2
that referenced
this pull request
Aug 28, 2020
Apparently expt.imageset.get_scan() is a different scan instance to expt.scan. As highlighted by dials/dials#1383 it it necessary to ensure that both scan objects have the same batch_offset.
ndevenish
pushed a commit
that referenced
this pull request
Sep 1, 2020
Gorilla of temporary workarounds for inconsistent scan and imageset slicing (cctbx/dxtbx#213). Also: Add slice_experiments test for #1382 Fixes #1382
Merged
ndevenish
pushed a commit
to xia2/xia2
that referenced
this pull request
Sep 1, 2020
Apparently expt.imageset.get_scan() is a different scan instance to expt.scan. As highlighted by dials/dials#1383 it it necessary to ensure that both scan objects have the same batch_offset.
ndevenish
added a commit
that referenced
this pull request
Sep 1, 2020
- ``dials.scale``: Prevent discarding of resolution limits in rare cases, which could cause incorrect symmetry determination, and worse results. (#1378) - ``dials.cosym``: filter out experiments with inconsistent unit cells (#1380) - Internally slicing experiments now works if image range doesn't start at 1 (#1383) - Restore missing I/sigma(I) resolution estimate log output (#1384) - ``dials.image_viewer``: "Save As" button now works, for single panels - Fix developer ``libtbx.precommit`` installation error (#1375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gorilla of temporary workarounds for inconsistent scan and imageset slicing
(cctbx/dxtbx#213).
Fixes #1382