Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile private post dont show error 404. Close #4128 #4129

Merged
merged 1 commit into from
May 18, 2013
Merged

Mobile private post dont show error 404. Close #4128 #4129

merged 1 commit into from
May 18, 2013

Conversation

movilla
Copy link
Contributor

@movilla movilla commented Apr 24, 2013

Fix #4128

@jhass
Copy link
Member

jhass commented Apr 24, 2013

Lets try some deduplication here:

not_public.haml

- content_for :head do
  = stylesheet_link_tag :error_pages, :media => 'all'

#big-number.transparent
    404

#content
  = t('error_messages.post_not_public')
  %br
  = t('error_messages.login_try_again', :login_link => new_user_session_path).html_safe

not_public.html.haml

- content_for :after_content do
  = render 'not_public'

not_public.mobile.haml

= render 'not_public'

Demonstrating the idea, untested.

@movilla
Copy link
Contributor Author

movilla commented Apr 24, 2013

Oks thanks. But I think it is easier still.

Simply deleting this "- content_for: after_content do" works correctly.

@movilla
Copy link
Contributor Author

movilla commented Apr 25, 2013

👍

@jhass jhass merged commit f17d163 into diaspora:develop May 18, 2013
@jhass
Copy link
Member

jhass commented May 18, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile private post dont show error 404
2 participants