-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] fix ResourceWarning from unclosed file #90
Conversation
Codecov ReportBase: 87.51% // Head: 87.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## latest #90 +/- ##
==========================================
+ Coverage 87.51% 87.53% +0.01%
==========================================
Files 15 15
Lines 633 634 +1
==========================================
+ Hits 554 555 +1
Misses 79 79
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Fixes #2394. The main update in screed from 1.0.5 to 1.1 was dib-lab/screed#90, which closes an unclosed file handle. This PR also puts an upper bound on the screed version. --------- Co-authored-by: Luiz Irber <contact+github@luizirber.org> Co-authored-by: Luiz Irber <luizirber@users.noreply.github.com>
make test
Did it pass the tests?make clean diff-cover
If it introduces new functionality, is it tested?make format diff_pylint_report doc
Is it well formatted?documented in
CHANGELOG.md
? See keepachangelogfor more details.
changes were made?