Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix ResourceWarning from unclosed file #90

Merged
merged 10 commits into from
Dec 3, 2022
Merged

Conversation

ctb
Copy link
Member

@ctb ctb commented Jan 19, 2022

  • Is it mergeable?
  • make test Did it pass the tests?
  • make clean diff-cover If it introduces new functionality, is it tested?
  • make format diff_pylint_report doc Is it well formatted?
  • For substantial changes or changes to the command-line interface, is it
    documented in CHANGELOG.md? See keepachangelog
    for more details.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Base: 87.51% // Head: 87.53% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b50683e) compared to base (e2232ae).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest      #90      +/-   ##
==========================================
+ Coverage   87.51%   87.53%   +0.01%     
==========================================
  Files          15       15              
  Lines         633      634       +1     
==========================================
+ Hits          554      555       +1     
  Misses         79       79              
Impacted Files Coverage Δ
screed/openscreed.py 92.51% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ctb ctb merged commit 0415c4d into latest Dec 3, 2022
@ctb ctb deleted the fix/open_resource branch December 3, 2022 22:45
ctb added a commit to sourmash-bio/sourmash that referenced this pull request Mar 5, 2023
Fixes #2394.

The main update in screed from 1.0.5 to 1.1 was
dib-lab/screed#90, which closes an unclosed file
handle.

This PR also puts an upper bound on the screed version.

---------

Co-authored-by: Luiz Irber <contact+github@luizirber.org>
Co-authored-by: Luiz Irber <luizirber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants