-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Add append option to sbt_index #120
Conversation
sourmash_lib/sbt.py
Outdated
@@ -167,13 +167,16 @@ def parent(self, pos): | |||
if pos == 0: | |||
return None | |||
p = int(math.floor((pos - 1) / self.d)) | |||
self.nodes[p] = self.nodes[p].do_load() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we merge #85, these .do_load
calls are not needed.
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 85.64% 85.67% +0.02%
==========================================
Files 13 13
Lines 1951 1954 +3
Branches 52 52
==========================================
+ Hits 1671 1674 +3
Misses 270 270
Partials 10 10
Continue to review full report at Codecov.
|
a294c26
to
255ff6a
Compare
255ff6a
to
36ba7b3
Compare
36ba7b3
to
2007c4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Updated & then merge! |
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?