Improve CI & fix bug in test spec/didww/client_spec.rb #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanov-Anton
force-pushed
the
new_branch
branch
3 times, most recently
from
1c4aa30 to
e276836
Compare
Ivanov-Anton
changed the title
|
My suggestion is to create a separate PR after merging these commits, to add support for rails 7 and ruby 3 as additional CI configurations. |
gigorok
reviewed
May 19, 2023
gigorok
reviewed
May 19, 2023
added 5 commits
May 19, 2023 18:20
…onment Previously, running the command "bundle exec rspec spec/didww/client_spec.rb" locally resulted in all tests passing. However, when executing a chain of test suites, a failure occurred due to a modification of the default api_mode from "sandbox" to "production" in the "spec/didww/client_spec.rb" specification file. I suggest to reload DIDWW::Client constant after this spec/didww/client_spec.rb specific test.
In Ruby, the Fixnum class has been deprecated since Ruby 2.4 and removed in Ruby 3. Instead, Ruby introduced the Integer class to encompass both Fixnums and Bignums.
Remove support for Ruby versions 2.5 and 2.6, as well as ActiveSupport "~> 5.0", since they are no longer maintained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses several issues and improvements in the codebase. Here's a summary of the changes made in each commit:
Commit: Ensure the use of "sandbox" as the default api_mode in the test environment.
Description: This commit fixes a failure that occurred when executing a chain of test suites due to a modification of the default api_mode from "sandbox" to "production" in the "spec/didww/client_spec.rb" specification file. To resolve this, I suggest reloading the DIDWW::Client constant after the specific test in "spec/didww/client_spec.rb".
Commit: Use Integer instead of Fixnum.
Description: In Ruby, the Fixnum class has been deprecated since Ruby 2.4 and removed in Ruby 3. Instead, the Integer class should be used, which encompasses both Fixnums and Bignums. This commit updates the codebase to use the Integer class.
Commit: Use ruby/setup-ruby@v1 instead of deprecated actions/setup-ruby@v1.
Description: The actions/setup-ruby@v1 action has been deprecated. This commit replaces it with the updated ruby/setup-ruby@v1 action to ensure compatibility and proper Ruby setup.
Commit: remove support ruby version 2.5, 2.6 and activesupport with 5.0.
Description: Remove support for Ruby versions 2.5 and 2.6, as well as ActiveSupport "~> 5.0", since they are no longer maintained.
closes #36