Add new features for DID Group resource #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigorok
reviewed
May 23, 2023
gigorok
reviewed
May 23, 2023
* removed DidGroup::FEATURE_VOICE => in favor DidGroup::FEATURE_VOICE_IN and DidGroup::FEATURE_VOICE_OUT * removed DidGroup::FEATURE_SMS => in favor DidGroup::FEATURE_SMS_IN and DidGroup::FEATURE_SMS_OUT
Ivanov-Anton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation, we have this list of features
https://doc.didww.com/api3/2022-05-10/coverage-resources/did-group/get-did-groups.html
So we have to update the
DIDWW::Resource::DidGroup::FEATURESfeature list to be up-to-date.closes #33