Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't fetch QIDs for all cited items if some already have QIDs #184

Closed
Dominic-DallOsto opened this issue Aug 27, 2022 · 0 comments · Fixed by #185
Closed

Can't fetch QIDs for all cited items if some already have QIDs #184

Dominic-DallOsto opened this issue Aug 27, 2022 · 0 comments · Fixed by #185
Assignees

Comments

@Dominic-DallOsto
Copy link
Collaborator

I found this issue while working on #137.

To reproduce:

  1. Have an item with multiple citations, none of which have a QID
  2. Fetch the QID for just one item
  3. Now try and fetch the QIDs for all the remaining items at once (from the More... menu)

I get TypeError: qidMap is undefined here

Tracing back, this is because Wikidata.reconcile exits here, without returning anything.

The purpose of the if statement is to abort reconciliation if the item we're dealing with already has a QID, and we won't overwrite it. But when working on multiple items at once we still want to continue with all the other items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant