Request to Re-export IntoConflictValueClause and UndecoratedInsertRecord to diesel::upsert

[Abhicodes-crypto]

While using on_conflict_do_nothing() function under a generic function. I get the error that IntoConflictValueClause and UndecoratedInsertRecord trait bounds are not satisfied. These traits are declared pub, but query_builder::upsert is a private module and hence these traits can't be imported.

It would be helpful if these traits are available for applications to import.

[Abhicodes-crypto]

Update : I am able to use this UndecoratedInsertRecord from diesel insert. I believe IntoConflictValueClause can also be made pub

[weiznich]

Types/Traits that are not publicly exported are private because we do not want to expose too much internals of diesel as stable API. This applies here as well. If you want to see a type as part of the public API I would expect such a proposal to include information about:

• Why this is necessary
• What alternatives there are (type aliases, other trait bounds, …)
• What implications it has in terms of what could or couldn't we change at a later point in time due to this change.