Update all the crates to the 2021 edition #3568
Conversation
| # hack to get a `diesel` item inside of diesel | ||
| # as well as for using diesel-derives in external crates | ||
| edition = "2015" | ||
| edition = "2021" |
There was a problem hiding this comment.
We needed it before #3564
I tried that migration already yesterday and noticed that dependencies. I did not think much about that and went on trying to minimize one of the rust-analyzer type issues with diesel, so that the rust-analyzer team had at least a minimal example without depending on diesel. While doing that someone from that team said that they cannot explain how name resolution even worked for code generated by diesel proc-macro. Because I hit that by accident a bit earlier I was able to explain that and they suggested the extern crate self as diesel; fix. That in turn remove the need to use the 2015 edition there, so after all that's all somehow related.
There was a problem hiding this comment.
Weird, I remember trying this exact trick when I was refactoring the derives. But, it didn't work back then, so I thought maybe the issue was something else and ended up keeping the old hack.
| #[cfg(feature = "sqlite")] | ||
| extern crate diesel_migrations; | ||
| extern crate dotenvy; | ||
| extern crate quickcheck; |
There was a problem hiding this comment.
That's fine. extern crate … statements are not required anymore, so we can remove them (even those with a #[cfg] on.)
This is mostly just running `cargo fix --edition` and `cargo fix --edition-idioms`
weiznich
force-pushed
the
update/edition_to_2021
branch
from
17bee10 to
aa28629
Compare
This is mostly just running
cargo fix --editionandcargo fix --edition-idioms