Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmless typo in parameter checking code #93

Open
egaffo opened this issue Apr 9, 2021 · 0 comments
Open

Harmless typo in parameter checking code #93

egaffo opened this issue Apr 9, 2021 · 0 comments

Comments

@egaffo
Copy link

egaffo commented Apr 9, 2021

line 149 of main.py
if (options.mate1 and not options.mate1) or (options.mate2 and not options.mate1) and options.pairedendindependent:
should be
if (options.mate1 and not options.mate2) or (options.mate2 and not options.mate1) and options.pairedendindependent:
?

Anyhow, the code eventually works as intended and this issue seems to be harmless.

Enrico

Edit: similar at line 204
if (not options.mate1 or not options.mate1) and options.pairedendindependent:
... perhaps I am missing some logic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant