Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No message displayed if no comparison results #125

Closed
eboileau opened this issue Jul 16, 2024 · 1 comment
Closed

No message displayed if no comparison results #125

eboileau opened this issue Jul 16, 2024 · 1 comment
Assignees
Labels
type:enhancement New feature or request

Comments

@eboileau
Copy link
Collaborator

Aims/objectives.

There is only an empty table, cf. Search No records match your search criteria!

A clear and concise description of todo items.

  • Add message
@eboileau eboileau added the type:enhancement New feature or request label Jul 16, 2024
@eboileau eboileau added this to the Second release milestone Jul 16, 2024
@eboileau eboileau self-assigned this Jul 16, 2024
@eboileau
Copy link
Collaborator Author

eboileau commented Jul 18, 2024

This is unrelated to this issue, but yet related to this component, so while working on this, look at the export header and the export file name (download.csv).

The export header is

chrom	chromStart	chromEnd	name	score	strand	eufid	coverage	frequency	chromB	chromStartB	chromEndB	nameB	scoreB	strandB	eufidB	coverageB	frequencyB	distance
  • Can we reformat it to either be consistent with the displayed header (As, Bs), or remove As, Bs completely, etc. The table headers also contains Reference dataset A and Reference dataset B, this might be misinterpreted, as there could be more than one dataset in either A or B.
  • Check what happen for multiple As, and for different operations.
  • In other tables, bedRMod fields are formatted according to the specs, the remaining fields are capitalized, etc.

eboileau added a commit that referenced this issue Aug 6, 2024
@eboileau eboileau closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant