Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider bumping default version of google-java-format from 1.1 to 1.2. #74

Closed
jbduncan opened this issue Jan 18, 2017 · 2 comments
Closed

Comments

@jbduncan
Copy link
Member

I think this is a worthwhile change to pursue, but before opening a PR, I want to understand the pros and cons of it.

These are the pros and cons I can think of at the moment:

Pros:

  • More "correct" behaviour by default.

Cons:

  • Can break people's builds if they depend on the default version being 1.1.
  • Requires a new version of spotless-lib (but that would be par for the course).
@nedtwigg
Copy link
Member

For the most part, I expect spotless-lib and spotless-plugin-xxx are going to release in lockstep. lib gets an upgrade, so we release a new set of spotless-plugin-xxx which point to that upgrade.

As far as newer formatters breaking older formatters, I think spotless defaults should always use the latest version of all available formatters. Users don't have to upgrade to new Spotless versions (I've got old projects sitting around on 1.x because they rely the old version of the eclipse formatter). And thanks to our classpath isolation introduced in Spotless 3.x, if they upgrade Spotless and are not happy with the new version of a dependendent library, they can always set the version of that library after the fact.

@jbduncan
Copy link
Member Author

Hi @nedtwigg, thanks for writing up your opinion on this!

Done in #73. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants