Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade annotations #274

Merged
merged 3 commits into from
Aug 3, 2018
Merged

Upgrade annotations #274

merged 3 commits into from
Aug 3, 2018

Conversation

KengoTODA
Copy link
Contributor

Thanks for your great product, I use this to keep my .md, .gradle and .java clean.
I want to suggest upgrading annotations:

  1. JSR305 annotation has 3.0.2 release maintained by amaembo, it has better pom and javadoc for users.
  2. According to SpotBugs migration guide, com.google.code.findbugs:annotations can be migrated to com.github.spotbugs:spotbugs-annotations and net.jcip:jcip-annotations.

@jbduncan
Copy link
Member

jbduncan commented Aug 2, 2018

Cool, thank you very much @KengoTODA for doing this!

  1. JSR305 annotation has 3.0.2 release maintained by amaembo, it has better pom and javadoc for users.

Hmm. I'm kind of curious: do you know who were the original maintainer(s) of the artifact?

Other than that, this LGTM! 👍

@nedtwigg, WDYT?

@KengoTODA
Copy link
Contributor Author

https://github.com/amaembo/jsr-305/tree/master/ri

It's maintained by amaembo, you can see commits in the above URL.

@KengoTODA
Copy link
Contributor Author

Its original copyright holder is a group led by the author of FindBugs. You can find its name at
https://github.com/amaembo/jsr-305/blob/master/ri/LICENSE

Amaembo was one of FindBugs maintainer.

@jbduncan
Copy link
Member

jbduncan commented Aug 3, 2018

Amaembo was one of FindBugs maintainer.

Oh brill, I wasn't aware of that! Thanks for enlightening me. :)

Since it's Amaembo we're talking about, I've no problems with upgrading the com.google.code.findbugs:jsr305 artifact from 3.0.0 to 3.0.2! Consider my "LGTM" confirmed. :)

But before merging this, I'd just like to hear @nedtwigg's thoughts first.

@jbduncan jbduncan requested a review from nedtwigg August 3, 2018 13:45
@nedtwigg
Copy link
Member

nedtwigg commented Aug 3, 2018

I use this to keep my .md, .gradle and .java clean spotless

FTFY ;-)

Sounds good to me, thanks for the PR!

@nedtwigg nedtwigg merged commit 2ac756d into diffplug:master Aug 3, 2018
@KengoTODA KengoTODA deleted the upgrade-annotations branch August 3, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants