Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Maven POM sorting/formatting #946

Merged
merged 14 commits into from
Sep 30, 2021
Merged

Added support for Maven POM sorting/formatting #946

merged 14 commits into from
Sep 30, 2021

Commits on Sep 27, 2021

  1. Added support for Maven POM sorting/formatting

    @tisoft
    tisoft committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    22ddb38 View commit details
    Browse the repository at this point in the history

  2. load SortPom from JarState

    @tisoft
    tisoft committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    503f4c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2021

  1. use FormatterFunc and SortPomState from current ClassLoader

    @tisoft
    tisoft committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    8b7c3eb View commit details
    Browse the repository at this point in the history

  2. Fixed SpotBugs errors

    @tisoft
    tisoft committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    c0d1b68 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Rename SortPomTest to SortPomMavenTest.

    @nedtwigg
    nedtwigg committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    680d95c View commit details
    Browse the repository at this point in the history

  2. Create a no-maven SortPomTest which can run quickly.

    @nedtwigg
    nedtwigg committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    4a80576 View commit details
    Browse the repository at this point in the history

  3. Rename SortPomState to SortPomCfg, and: 

    - SortPomCfg needs no dependencies, just Strings and booleans
- SortPomCfg now has the default values, which simplifies plugin-maven/.../SortPom.java
- SortPomStep does the JarState and classloader stuff
    @nedtwigg
    nedtwigg committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    f2c0e4a View commit details
    Browse the repository at this point in the history

  4. FeatureClassLoader now loads com.diffplug.spotless.glue.* via `def… 

    …ineClass`, and `com.diffplug.spotless` with `buildToolClassLoader`. This unifies FeatureClassLoader with DelegatingClassLoader.
    @nedtwigg
    nedtwigg committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    bcd3735 View commit details
    Browse the repository at this point in the history

  5. SortPomStep can now live within the normal src/main/java, and only … 

    …`SortPomFormatterFunc` needs `src/sortPom/java`.
    @nedtwigg
    nedtwigg committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    4b780c0 View commit details
    Browse the repository at this point in the history

  6. Fix typo.

    @nedtwigg
    nedtwigg committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    6d6ab66 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Fix FeatureClassLoader for eclipse entries.

    @nedtwigg
    nedtwigg committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    24bc908 View commit details
    Browse the repository at this point in the history

  2. plugin-maven doesn't need any special dependency on the lib jar.

    @nedtwigg
    nedtwigg committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    2b85d84 View commit details
    Browse the repository at this point in the history

  3. Generalize the sortPom stuff to facilitate diffplug#524 (glue code).

    @nedtwigg
    nedtwigg committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    b95e93b View commit details
    Browse the repository at this point in the history

  4. Added documentation for sortPom

    @tisoft
    tisoft committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    617abf5 View commit details
    Browse the repository at this point in the history