fix: Fix iss claim in dialog token #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MagnusSandgren
approved these changes
Aug 26, 2024
oskogstad
pushed a commit
that referenced
this pull request
Sep 4, 2024
🤖 I have created a release *beep* *boop* --- ## [1.16.0](v1.15.0...v1.16.0) (2024-09-04) ### Features * **webapi:** Require legacy scope for HTML support ([#1073](#1073)) ([03237cc](03237cc)) * **webAPI:** Require UUIDv7 ([#1032](#1032)) ([e9b844f](e9b844f)) ### Bug Fixes * Fix iss claim in dialog token ([#1047](#1047)) ([9ab4a85](9ab4a85)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the
issclaim getting either two slashes or no slashes after the base uri part, due someUriToString() behaviour I do not fully understand.Before this fix, tokens made on test (any other environment than localdev) missed a slash resulting in
issclaim beinghttps://altinn-dev-api.azure-api.net/dialogportenapi/v1. This was due to the call toGetDialogTokenmissing a leading slash. However, this resulted in double slashes when running locally, iehttps://localhost:7247//api/v1. Both configurations are defined withBaseUrivalues without trailing slashes.The fix consists of adding a leading slash to the
GetDialogTokencall, and trimming any trailing slash from theBaseUriwhen concatenating inDialogGeneratorRelated Issue(s)
Verification