Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL scema missing MediaType on attachment URL #1263

Closed
oskogstad opened this issue Oct 10, 2024 · 3 comments
Closed

GraphQL scema missing MediaType on attachment URL #1263

oskogstad opened this issue Oct 10, 2024 · 3 comments
Assignees
@oskogstad
Labels
bug Something isn't working

Comments

@oskogstad
Copy link
Collaborator

No description provided.

@oskogstad oskogstad added the bug Something isn't working label Oct 10, 2024
@oskogstad oskogstad self-assigned this Oct 10, 2024
@oskogstad oskogstad mentioned this issue Oct 10, 2024
Merged
4 tasks
oskogstad added a commit that referenced this issue Oct 10, 2024
@oskogstad
fix(graphQL): Missing MediaType on dialog attachment url (#1264)
3919343 
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Related Issue(s)

- #1263

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new `mediaType` field in the `AttachmentUrl` type for
specifying the media type of attachments.
  
- **Bug Fixes**
- Corrected formatting issue by ensuring the `UUID` scalar type
definition ends with a newline character.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@elsand elsand closed this as completed Oct 14, 2024
@LeifHelstad
Copy link

LeifHelstad commented Nov 5, 2024 •
edited
Loading

Resultat og Testdata

image

Å hente opp dialog-id 0192fc66-8478-74ae-8dac-60712b562fb8 viser at mediaType er lagret. Det er i og for seg tilstrekkelig test av endringen.

Observasjon jeg likevel ønsker å sjekke litt:
@seanes mediatype er Sting og den er satt, men ikke til noe som er en reell mediatype.
Når jeg henter dialogen tilbake med dialog-id så huskes mediaType, så den er lagret i dialogen.

Men hvordan skal frontend forholde seg til mediatype her? Skal den uansett ikke være synlig i devtools? Eller ignoreres den fordi den har en "ugyldig" verdi?

@seanes
Copy link

seanes commented Nov 5, 2024

@LeifHelstad Den brukes ikke p.t. nå

@LeifHelstad
Copy link

Jeg anser testen som passert da jeg kan lese tilbake veriden med get på dialog-id.

At frontend ikke har tatt i bruk verdien ennå betyr bare at det alltid vil vises default-ikon.
image
(Da blir det etterhvert egen frontend sak på ikonvalg.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskogstad oskogstad

Labels
bug Something isn't working
Projects
Dialogporten / Arbeidsflate - NY
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@elsand @seanes @oskogstad @LeifHelstad