feat: Add authorization caching #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arealmaas
previously approved these changes
Apr 4, 2024
|
oskogstad
approved these changes
Apr 10, 2024
oskogstad
pushed a commit
that referenced
this pull request
May 7, 2024
🤖 I have created a release *beep* *boop* --- ## [1.6.0](v1.5.0...v1.6.0) (2024-05-07) ### Features * Add authorization caching ([#591](#591)) ([2f86d7e](2f86d7e)) * Add GraphQL POC ([#636](#636)) ([c779eac](c779eac)) * Add support for apps as serviceresource ([#658](#658)) ([adf91ce](adf91ce)) * Authorized parties endpoint in enduser API ([#661](#661)) ([050ccbb](050ccbb)) ### Bug Fixes * Accept app references with urn:altinn:resource prefix ([#685](#685)) ([c9a5606](c9a5606)) * ensure performed by is set for activities ([#628](#628)) ([1adf075](1adf075)) * Use HttpClient wrappers that ensure success to match FusionCache expectations ([#684](#684)) ([7c1e966](7c1e966)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds caching to the details- and search authorization calls. Keys are derived from the request models, using only the principal claims relevant for user identification (skipping
jti,expetc which will needlessly bloat the number of keys and reduce hit rate).This will create several keys per user, and for some bulk-operating end user systems, potentially thousands within the total TTL of the entries. To control RAM usage, memory cache is disabled and this relies solely on the Redis cache. This trades replica memory usage against Redis ingress/egress. For end user systems performing each search/details request just once, this makes no difference (as calls will miss the cache anyway), but for normal users in the portal which might navigate back and forth and change ordering/non-auth-related filters, the Redis traffic will increase compared to having the memory level cache enabled.